search

ahupp / python-magic

A python wrapper for libmagic
Other
2.64k stars 283 forks source link

Appveyor build fails since upgrading to python-magic v0.4.18 #216

Closed h3llrais3r closed 3 years ago

h3llrais3r commented 4 years ago

Since I upgraded to the latest version 0.4.18 of python-magic, my appveyor build keeps crashing after running my tests (although my tests are all successful). Build just before upgrade: https://ci.appveyor.com/project/h3llrais3r/auto-subliminal/builds/33085854/job/fps9g20few2tihb0 Build just after upgrade: https://ci.appveyor.com/project/h3llrais3r/auto-subliminal/builds/33085978/job/pohlxi9iga7ekr0f

When I'm running it on my own machine (Windows 10 x64), I don't have the issue. It seems to be only when running it on appveyor running Windows Server 2012 R2 (travis builds on unix/linux are running without any problems).

Any idea what could be wrong? Sadly I can't find any additional info in the build itself.

ahupp commented 4 years ago

The only reason I can think of for a crash on shutdown is something in the destructor. Where did you get the libmagic binary for windows? Is it possible to run the appveyor test manually?

h3llrais3r commented 4 years ago

I only installed python-magic via pip and included it in my project lib folder. I only have the magic.py in my lib folder. Running it on Windows 10 on my own pc works without issues. It's only the appveyor build on Windows server 2012 R2 that fails.

I did not install any dll's for windows...

ahupp commented 4 years ago

Any more information about this?

h3llrais3r commented 4 years ago

What extra info do you require?

ahupp commented 4 years ago

What libmagic dlls are you using on Windows? Can you share the output of the failure? Its not available afaict at the link above.
Ideally, can you give me an environment that reproduces this failure?

h3llrais3r commented 4 years ago

I didn't install any dll's on windows. Sorry, link was not correct. I updated link of failing build in OP. It's https://ci.appveyor.com/project/h3llrais3r/auto-subliminal/builds/33085978/job/pohlxi9iga7ekr0f

Reverting to previous version fixed the build issue: https://ci.appveyor.com/project/h3llrais3r/auto-subliminal/builds/33086284/job/er6lbq2jfq3b6i1p

ahupp commented 4 years ago

Are you using the python-magic-bin package?

If you remove Magic.__del__ does this stop happening? I wonder if there's some order of destruction issue, like it's trying to free memory after the dll is unloaded.

h3llrais3r commented 4 years ago

No, I'm just installing python-magic via pip in my lib directory. And I only keep the magic.py file, nothing else.

ahupp commented 4 years ago

The python-magic project does not include a dll, so you must be getting it from somewhere else. There is a python-magic-bin project that does include the dll, in case you might be using that instead.

h3llrais3r commented 4 years ago

@ahupp, I did not install anything except python-magic through pip. Actually, I installed it as a depedency of another library I'm using, so I'm not even sure it's actually being used. I only noticed that from the moment I installed version 0.4.18, it started to give problems on the appveyor build. Reverting it, solves the issue. Sadly there are no details in the logging about what's the exact issue...

h3llrais3r commented 3 years ago

Closing as I´m no longer using appveyor.