ahupp / python-magic

A python wrapper for libmagic
Other
2.59k stars 280 forks source link

GitHub Actions: Add testing on Windows #322

Open cclauss opened 3 months ago

cclauss commented 3 months ago

Currently testing on Windows is commented out in our GitHub Actions. https://github.com/ahupp/python-magic/blob/aa49677fbec9a4fc96b54e42c2517a2118d66db8/.github/workflows/ci.yml#L13-L14

Linux and macOS work just fine but on Windows the tests never complete.

ddelange commented 3 months ago

here are the pytest failues on windows: https://github.com/ahupp/python-magic/pull/294#discussion_r1590782796

when they're fixed (or skipped), we could re-introduce pytest in wheels.yml (https://github.com/ahupp/python-magic/commit/84667ee7d3d6bbc6bcf2400105ed322de22417fa) to get proper platform tests:

cclauss commented 3 months ago

I prefer a test job that runs the tests. And a separate wheels / deployment job that is focused on moving to production. However I don’t want to do anything that slows down this PR.