search

ahutchings / kohana-modules

The kohana-modules.com module "database".
http://kohana-modules.com/pages/add-a-module
93 stars 79 forks source link

Please check before adding modules to the repository #190

Open WinterSilence opened 10 years ago

WinterSilence commented 10 years ago

Most of the new modules do not meet the standards Kohana, low quality code, not contain comments, for example: all modules by madeinnordeste, /mgalang/kohana-elasticsearch.

fix for madeinnordeste/kohana-net

Please add only "serious" modules, because the repository used junior programmers.

seyfer commented 9 years ago

Also i think devs need better manual for adding modules in wiki or readme or on site.

When I fork repo I should only edit .gitmodules or also use command like git submodule update

? It's not clear.

ahutchings commented 9 years ago

Please add only "serious" modules, because the repository used junior programmers.

I don't want to exclude modules based on a subjective assessment of code quality. I would be open to some sort of automated analysis to confirm that a module is compatible with a certain version of Kohana, however.

Also i think devs need better manual for adding modules in wiki or readme or on site.

I agree that kohana-modules.com needs better documentation regarding how to submit a module. I usually run git submodule add https://github.com/kohana/auth.git, for example, if I wanted to add the auth module to a branch. Here's the page that should be edited if anyone wants to submit a pull request:

Add a Module (Source in GitHub)

I'm closing this issue, but I'm open to a pull request for improving the "Add a Module" page.

seyfer commented 9 years ago

If you close this issue - no one can see the existed problem and the problem gonna became forgotten..

ahutchings commented 9 years ago

That's fair, reopening until the documentation issue is resolved.