search

ahuth / preview-tabs

Sublime-style preview tabs for Atom
MIT License
11 stars 2 forks source link

Weird behavior when dragging tabs around #5

Closed abe33 closed 10 years ago

abe33 commented 10 years ago

Initially reported in atom/bracket-matcher#76 as it triggers an error in the bracket-matcher package. But I could narrow down the issue to the preview-tabs package, when dragging a persisted tab for the first time, the tab become a preview tab, after more dragging I guess the tab editor is destroyed, leading to an error in the bracket-matcher package.

ahuth commented 10 years ago

Thanks for bringing this up, and being able to reproduce it. And you're exactly right: the tab is becoming a 'preview', and then it's getting destroyed.

Later today, I'll work on making sure that it does not become 'previewed' when a tab is drag-and-dropped from one pane to another.

ahuth commented 10 years ago

This has been fixed in master. I'm going to work on a few more things this weekend, and hopefully push out a release with this fix tomorrow.

Thanks for bringing this up.

ahuth commented 10 years ago

Just pushed v1.0.4, which fixes this.

Thanks.