search

ahx / openapi_first

openapi_first is a Ruby gem for request / response validation and contract-testing against an OpenAPI API description. It makes APIFirst easy and reliable.
MIT License
97 stars 12 forks source link

Bump json_schemer from 2.1.0 to 2.2.0 #257

Closed RinseV closed 2 months ago

RinseV commented 2 months ago

I'm trying to use this gem for validating my OpenAPI schema against the responses from my controllers by replacing committee with this gem. I'm also using the activerecord_json_validator gem which requires json_schemer ~> 2.2.0. Currently, openapi_first requires json_schemer ~> 2.1.0 which is causing a mismatch in my dependencies. I am currently using version 3.0.0 of activerecord_json_validator. Unfortunately, there is no way to use json_schemer 2.1.0 with version 3.x of activerecord_json_validator since 3.0.0 of activerecord_json_validator requires json_schemer 2.1.x.

As such, I've updated the version of json_schemer in this gem to resolve this conflict if you're trying to use this gem together with version 3.0.0 of activerecord_json_validator.

As far as I can tell, the version of json_schemer can be safely updated to 2.2.0 (see changelog here). The only change that affects this library is the change in the validation error message for additionalProperties as changed in this commit. As such, I've updated the spec to reflect this change.

Let me know if any other changes are required.

ahx commented 2 months ago

This has just been released in 1.4.3

RinseV commented 2 months ago

Thank you so much for the incredibly quick turn-around! I'm happy to report that I can now use both openapi_first & activerecord_json_validator without having to downgrade either package

ahx commented 2 months ago

Happy to help. Any feedback, wish-lists, complains or ideas about this gem would be greatly appreciated.