search

ahyatt / ekg

The emacs knowledge graph, app for notes and structured data.
GNU General Public License v3.0
230 stars 19 forks source link

Several trivial changes #133

Closed qingshuizheng closed 9 months ago

qingshuizheng commented 9 months ago

Hello Andrew,

In this PR, several changes are made:

  1. Internalize func name: ekg-kill-buffer-query-function -> ekg--kill-buffer-query-function ; ekg-header-line-format -> ekg--header-line-format

  2. Remove redundant code in the definition of ekg-capture-mode, which is already included in (ekg--set-local-variables)

  3. ekg-clean-dup-tags should act on every tag, instead of only the incomplete (ekg-tags).

  4. Insert newest note on top of ekg-notes-mode by default for easy browsing. The cursor will jump to the the top of buffer on every refresh. Put the newest note on top will make it easy to find.

  5. Also insert newly captured note to the ekg-show-notes-latest-{modified,captured} buffer.

  6. Refresh only the edited note, instead of refreshing all the notes for better performance, and avoid cursor jumping around.

  7. Simplify code: ekg-display-note-titled, ekg-notes-{next,prev}

  8. Fix broken auto-save-predicate example for corfu.

  9. Exclude existing tags from completion table in ekg--tags-complete

  10. Insert ": " after ekg--field-name-complete finishes

Let me know what you think and feel free to take or reject any of them.

Zheng

ahyatt commented 9 months ago

Thank you for this change! FYI, I'm going to be flying and on vacation in the next 2 weeks, but I'll have time to look this over. But it might not be for a few days.

qingshuizheng commented 9 months ago

Wow, enjoy the vacations! 🍾 Just leave everything here as is until you come back.

ahyatt commented 9 months ago

Thanks - I think this looks good! I'm hoping to merge this in and release 0.5 after a bit more of testing. I take it your last commit has fixed whatever you needed to have fixed, and it's ready to merge in?

qingshuizheng commented 9 months ago

I'm hoping to merge this in and release 0.5 after a bit more of testing.

Sure. And welcome to rebase them or do whatever change you think it should.

I take it your last commit has fixed whatever you needed to have fixed, and it's ready to merge in?

Correct. I won't push any more commit from here. Only exception is that there are issues needs to be addressed. But I'll let you know then.

Enjoy the vacation!

ahyatt commented 9 months ago

Thank you for the fixes, and your continued improvements to this project!

qingshuizheng commented 9 months ago

Ahh, no problem at all. This is the only knowledge graph project I understand the best. Will continue to hack on it! Thanks for the merge.