search

ahyatt / llm

A package abstracting llm capabilities for emacs.
GNU General Public License v3.0
142 stars 19 forks source link

Add CI #24

Closed s-kostyaev closed 4 months ago

s-kostyaev commented 4 months ago

Add github actions CI

s-kostyaev commented 4 months ago

It kinda works https://github.com/s-kostyaev/llm/actions/runs/8024702759?pr=1 @ahyatt

ahyatt commented 4 months ago

Thank you, I really appreciate this, and it looks very useful.

A concern I have from looking at the code, is that I don't think it is correct or desirable to have package statements on files that are not the main package file. Perhaps when I try this out myself I can see some way to disable some specific check. WDYT?

s-kostyaev commented 4 months ago

I think the same. See https://github.com/s-kostyaev/llm/pull/2

s-kostyaev commented 4 months ago

It should work - https://github.com/leotaku/elisp-check/issues/19 But it didn't. Maybe I will try to continue tomorrow

s-kostyaev commented 4 months ago

Maybe related - https://github.com/leotaku/elisp-check/issues/22

s-kostyaev commented 4 months ago

Done. @ahyatt feel free to fix warnings from CI yourself 😄

ahyatt commented 4 months ago

Thank you for the contribution! I'll go through how it is working and fix any issues I see.