Update media type and event source packages

ahyatt / llm

A package abstracting llm capabilities for emacs.

GNU General Public License v3.0

178 stars 24 forks source link

Update media type and event source packages #40

Closed r0man closed 6 months ago

r0man commented 6 months ago

This PR updates the media type and event source packages.

I moved the decoding from the process filter to the media type. Not everything should be decoded, e.g. binary data, and some media types have a default encoding (text/event-stream is always UTF-8 for example).
The plz-media-type:text/event-stream got renamed to plz-event-source:text/event-stream to reflect the package in which it is defined.
Fixed some lint issues in the event source package

r0man commented 6 months ago

Hi @ahyatt,

here is a small update. Would you like to merge this PR?

How are things going otherwise? I'm using the plz branch of the llm library since a while and haven't noticed anything bad. The providers I'm using are mostly OpenAI and a bit of Vertex.

I'm still waiting for the FSF paperwork to complete and the PR on plz to move things forward.

How are things on your side? Are you using the plz branch? Did you notice anything that needs to be fixed/improved?

Happy easter, Roman

ahyatt commented 6 months ago

Thanks, I'll merge this! I haven't been using plz, mainly because I'm working on refactoring everything to use generics, which will be a big win. But it's taking a while. Once I'm done with that (maybe today?), I'll have to adapt things to plz again, so I may have some additional requests. But I think it should be largely straightforward.