search

ahyatt / llm

A package abstracting llm capabilities for emacs.
GNU General Public License v3.0
142 stars 19 forks source link

Change some function names and make most of them private #42

Closed r0man closed 2 months ago

r0man commented 3 months ago

Hi @ahyatt,

here is another PR. It changes nothing in llm itself, and otherwise just renames some functions and makes most of them private. Once we have a new version of plz with the filter option releases I plan to tag a release (with the bumped plz dependency) and send this to emacs-devel.

I open the PR here, so we can use this version of plz-media-type and plz-event-source for testing in the meantime, which I'm going to do today. I can try it again on Ollama, OpenAI and Vertex. I'm AWFK until Saturday. I hope that Craig responded by then. I pinged him again yesterday. Once we have the plz release with the filter option I will send an email to emacs-devel and ask for adding the libraries to ELPA.

ahyatt commented 2 months ago

Thanks for these changes! Here's the next steps as far as I understand:

You need to open up a discussion on emacs-devel@ on your proposed package: is it a good idea, is it OK if it is just for plz (I think that's probably necessary), and mentioning that it is temporarily part of this package.

Once that discussion is resolved (cc me if possible), I can merge this branch to the main branch and deploy it. I have one major change on the main branch to get out before I get this out.

Once, again, thank you for this valuable contribution!