search

ai-cfia / ailab-datastore

This is a repo representing the data layer of multiple ailab projects
MIT License
2 stars 0 forks source link

176 as a dev i want company fields to be correctly persisted during analysis registration #178

Closed Francois-Werbrouck closed 1 month ago

Francois-Werbrouck commented 1 month ago

This PR adds test to confirm #176 is patched

Francois-Werbrouck commented 1 month ago

@k-allagbe I advide only reviewing the last 2 commits with #176 in their title, since the rest is based on our other branch

k-allagbe commented 1 month ago

This commit seems to be missing: https://github.com/ai-cfia/ailab-datastore/pull/159/commits/e89bc9d14b3be9a63dc9137b3d9d0dd6d26db9db

Francois-Werbrouck commented 1 month ago

Ohhh it might of been done on the wrong branch. I'll rebase and add it

Francois-Werbrouck commented 1 month ago

This commit seems to be missing: e89bc9d

This is fixed now

k-allagbe commented 1 month ago

The main branch is now clean. I suggest opening a new PR where only the fix would be implemented and close this one. The current one has a lot of noise that could introduce regressions or break stuff on main.

k-allagbe commented 1 month ago

Never mind, this has already been merged. Closing this as done in #197.

Francois-Werbrouck commented 1 month ago

This was not merged in #197. The actual sql fix was pushed on the branch; however the tests haven't

Francois-Werbrouck commented 1 month ago

the current one has a lot of noise that could introduce regressions or break stuff on main.

I should only require a rebase for it to work. I'll look into it. Once again, not having multiple merge and only doing a rebase on the original PR would of made this not needed 👍🏻

Francois-Werbrouck commented 1 month ago

Rebase is now done. There are no conflicts with main. The newly added tests are passing. This is ready for Review