search

ai-cfia / finesse-frontend

Frontend for finesse, a semantic search product
MIT License
1 stars 4 forks source link

Implement sticky search bar feature #148

Open MehekFatima opened 6 months ago

MehekFatima commented 6 months ago

This PR introduces a new feature to make the search bar sticky at the top of the page while scrolling through search results.

MehekFatima commented 6 months ago

Hi @CFIALeronB @rngadam @vivalareda @k-allagbe , Could you please take a moment to review my PR? Your feedback would be greatly appreciated. Thanks!"

MehekFatima commented 6 months ago

Thank you for your feedback! I'll make the necessary changes and resubmit the PR as soon as possible. If there are specific areas you'd like me to focus on, please let me know. Thanks again for your guidance! @k-allagbe

MehekFatima commented 6 months ago

Thank you for the review! I've made the search bar sticky by applying the position: sticky property directly to the InputWrapper styled component. I'm still learning, so please let me know if there are any further improvements or suggestions. Apologies for any mistakes. @k-allagbe

k-allagbe commented 6 months ago

Hello @MehekFatima. No need to apologize, really. As a matter of fact, this allowed me to see another flaw in our system: #151. I believe it would be beneficial for everyone to have a way to populate the page with fake results. That would allow testing new features without needing to connect to finesse-backend. So thank you.

In the meantime, I would suggest you populate a fake result list yourself and test your solution. Once the requirements are met, please also write the automated tests for your implementation.

MehekFatima commented 6 months ago

Hi @k-allagbe , Thank you for your understanding and constructive feedback. I'm glad that this situation has helped identify another area for improvement in our system.

I completely agree that having a way to populate the page with fake results would be extremely beneficial for testing new features without the need to connect to finesse-backend. I'll prioritize implementing this feature as soon as possible.

In the meantime, I'll populate a fake result list myself to test the solution thoroughly. Once the requirements are met, I'll proceed to write automated tests for the implementation to ensure its reliability.