search

ai-cfia / flask-example

A minimal flask backend app that can serve as starting point for other backend projects.
0 stars 0 forks source link

Issue1-import-testapp1-code #2

Closed k-allagbe closed 7 months ago

k-allagbe commented 10 months ago

Closes #1 issue1-import-testapp1-code

Importation done. Refactored to remove code smells. Unit tests pass. Manual tests (auth scenario) done.

rngadam commented 9 months ago

Between the tests and the relentless changes, I think this is really nice.

I'd probably want to test

  1. that the Membrane functionality actually works when deployed
  2. test with a newbie developer if they are able to use it properly

@k-allagbe you asked for review but I see this is still draft. Can you make a checklist in the description of the PR to list what other changes (if any) you are planning to make? If not, maybe turn off the Draft flag?

Also would expect a README.md to complement the code.

I think we should get this merged as this is supposed to be our application example.