ai-cfia / membrane-backend

Membrane Backend: A centralized authentication service for Single Sign-On (SSO) enabling seamless token-based email verification across multiple client applications.
MIT License
1 stars 0 forks source link

Remove `SESSION_LIFETIME_MINUTES` and Rename `REDIRECT_URL_TO_LOUIS_FRONTEND` #37

Open CFIALeronB opened 1 year ago

CFIALeronB commented 1 year ago

Description:

In the course of refining the Louis login backend, certain environment variables have become redundant or inaccurately named.

1. Removal of SESSION_LIFETIME_MINUTES: The Louis login backend has evolved to a point where it doesn't save any session data. Therefore, the SESSION_LIFETIME_MINUTES environment variable, which was intended to define the session duration, is no longer necessary. It should be removed from the codebase and any related documentation to avoid confusion.

2. Rename REDIRECT_URL_TO_LOUIS_FRONTEND: The variable name REDIRECT_URL_TO_LOUIS_FRONTEND doesn't reflect its purpose accurately. It should be renamed to REDIRECT_URL_TO_LOGIN_FRONTEND to provide clarity on its function.

Tasks:

  1. Search for and remove all instances of SESSION_LIFETIME_MINUTES from the codebase.
  2. Update any documentation that references SESSION_LIFETIME_MINUTES to indicate its removal.
  3. Rename REDIRECT_URL_TO_LOUIS_FRONTEND to REDIRECT_URL_TO_LOGIN_FRONTEND throughout the code.
  4. Update all documentation and config files to reflect the renamed variable.
  5. Ensure that the renaming doesn't cause any breaks in the functionality.

Expected Outcome: