ai-cfia / nachet-backend

A flask-based backend for Nachet to handle Azure endpoint and Azure storage API requests from the frontend.
MIT License
1 stars 4 forks source link

Docker Azure deployment action #40

Closed ThomasCardin closed 7 months ago

ThomasCardin commented 8 months ago
ThomasCardin commented 7 months ago

rework your commit history to link to issue and provide a meaningful commit message

done @rngadam

ThomasCardin commented 7 months ago

@rngadam

Considering that we frequently switch between cloud accounts (Azure, AWS, GCP), wouldn't it be better to simply push our images to our GitHub instead? It would allow us to stop constantly changing our credentials in the github secrets. I could take care of making the changes in the repositories if I have the green light.

rngadam commented 7 months ago

Considering that we frequently switch between cloud accounts (Azure, AWS, GCP), wouldn't it be better to simply push our images to our GitHub instead? It would allow us to stop constantly changing our credentials in the github secrets. I could take care of making the changes in the repositories if I have the green light.

sound reasonable

ThomasCardin commented 7 months ago

Considering that we frequently switch between cloud accounts (Azure, AWS, GCP), wouldn't it be better to simply push our images to our GitHub instead? It would allow us to stop constantly changing our credentials in the github secrets. I could take care of making the changes in the repositories if I have the green light.

sound reasonable

Ok, then i'm closing this PR since we are now pushing images to the Github container registry (GCR)