Closed ThomasCardin closed 1 month ago
also fix markdown check fails
it's working now, but failing for another reason
also fix markdown check fails
it's working now, but failing for another reason
Would it be a good idea to turn this into Draft until you've fixed the failing checks?
@ThomasCardin spelling of useful is one l
@rngadam ping. I'm waiting for this pull request before I can proceed with this one: https://github.com/ai-cfia/infra/pull/4. (change de default tag of the docker image inside each kubernetes deployment to main
see (https://github.com/ai-cfia/infra/pull/4#discussion_r1457940126))
@rngadam ping. I'm waiting for this pull request before I can proceed with this one: ai-cfia/infra#4. (change de default tag of the docker image inside each kubernetes deployment to
main
see (ai-cfia/infra#4 (comment)))
the test is failing (lint-test step failing)
Out of scope of this issue
Out of scope of this issue
it is not out of scope; tests need to be green in a pull request before it gets merged.
The error was coming from using a Mock object instead of a MagicMock object (to be able to use the __iter__
) function. It was solved on
Does this PR still need to be pushed to main, or are the workflows being pushed already?
@ThomasCardin @rngadam
The error was coming from using a Mock object instead of a MagicMock object (to be able to use the
__iter__
) function. It was solved onDoes this PR still need to be pushed to main, or are the workflows being pushed already?
@ThomasCardin @rngadam
@ThomasCardin since this is fixed in main, this pull request should be rebased to get the tests to pass to allow for merging.
The current workflow (build and push docker images to this organisation registry) is working but the workflow it self is missing steps.
Workflow included: