issue #46: Add every useful workflow for this repository

ai-cfia / nachet-backend

A flask-based backend for Nachet to handle Azure endpoint and Azure storage API requests from the frontend.

MIT License

1 stars 4 forks source link

issue #46: Add every useful workflow for this repository #49

Closed ThomasCardin closed 1 month ago

ThomasCardin commented 7 months ago

The current workflow (build and push docker images to this organisation registry) is working but the workflow it self is missing steps.

Workflow included:

[X] Lint test
[X] Markdown validation
[X] ai-cfia repo standard
[X] build and push to github container registry (GCR)

ThomasCardin commented 7 months ago

also fix markdown check fails

it's working now, but failing for another reason

rngadam commented 7 months ago

also fix markdown check fails

it's working now, but failing for another reason

Would it be a good idea to turn this into Draft until you've fixed the failing checks?

rngadam commented 7 months ago

@ThomasCardin spelling of useful is one l

ThomasCardin commented 6 months ago

@rngadam ping. I'm waiting for this pull request before I can proceed with this one: https://github.com/ai-cfia/infra/pull/4. (change de default tag of the docker image inside each kubernetes deployment to main see (https://github.com/ai-cfia/infra/pull/4#discussion_r1457940126))

rngadam commented 6 months ago

@rngadam ping. I'm waiting for this pull request before I can proceed with this one: ai-cfia/infra#4. (change de default tag of the docker image inside each kubernetes deployment to main see (ai-cfia/infra#4 (comment)))

the test is failing (lint-test step failing)

ThomasCardin commented 6 months ago

Out of scope of this issue

rngadam commented 6 months ago

Out of scope of this issue

it is not out of scope; tests need to be green in a pull request before it gets merged.

MaxenceGui commented 5 months ago

The error was coming from using a Mock object instead of a MagicMock object (to be able to use the __iter__ ) function. It was solved on

Does this PR still need to be pushed to main, or are the workflows being pushed already?

@ThomasCardin @rngadam

rngadam commented 5 months ago

The error was coming from using a Mock object instead of a MagicMock object (to be able to use the __iter__ ) function. It was solved on

fixes #31: add a docs folder with Nachet inference documentation #53

Does this PR still need to be pushed to main, or are the workflows being pushed already?

@ThomasCardin @rngadam

@ThomasCardin since this is fixed in main, this pull request should be rebased to get the tests to pass to allow for merging.