Closed MaxenceGui closed 3 months ago
I've added model documentation from the backend. It is still a work in progress. Following this doc, here is a list of what's left to do in the code:
I'm asking for reviews from:
To access the new documentation: docs/nachet-model-documentation.md
@MaxenceGui New issues were created related to the work here so we can postpone some of the work and get this huge PR merged in main.
Modify the description to add checklist items as completed by referencing postponed tasks to new issues; this gives us a trace between the work that should have been done here and follow up issues.
@MaxenceGui New issues were created related to the work here so we can postpone some of the work and get this huge PR merged in main.
Modify the description to add checklist items as completed by referencing postponed tasks to new issues; this gives us a trace between the work that should have been done here and follow up issues.
Perfect, will do that. I push my last commit so all checks pass. @RussellJimmies and @rngadam if there is any last-minute review you wanna add, go ahead. If you approve this PR I will rebase and push it to main.
Seems like the issue links are created manually in the description? I think they look nicer if you use this notation:
* issue #59
* issue #61
* issue #60
output:
Seems like the issue links are created manually in the description? I think they look nicer if you use this notation:
It is I will absolutely change it
As discussed yesterday, the code here does not seem to be going in the right direction in terms of readability, testability and simplicity
the code is much improved from when I wrote this comment
@rngadam in case this PR is still far away in your notification
@RussellJimmies @ibrahim-kabir please revisit, verify fixes and update/resolve conversations as necessary.
@MaxenceGui needs to be rebased, conflicts with main.
Create issue to follow up with tiny title in Mermaid:
I understand that there's a follow up PR that depends on this one being checked in first
Yes! I Will correct markdown lint error and rebase before merging into main.
@RussellJimmies just missing your approval before merging in with main