ai-cfia / nachet-backend

A flask-based backend for Nachet to handle Azure endpoint and Azure storage API requests from the frontend.
MIT License
1 stars 4 forks source link

Red box error #67

Closed MaxenceGui closed 6 months ago

MaxenceGui commented 6 months ago

The process_inference_results function has been fixed to ensure that red boxes are adjusted and marked as overlapped only when one has a score that is strictly superior to the other. Additionally, a test has been added to verify the functionality of the modified function.

  • issue #62

I took Bryan's change and modified the check to see if the common area of the two boxes is bigger than 50% of their respective area before labeling them as overlapping.

Docker image failed, after discussing with @ThomasCardin, this error is not yet managed. Once this pull request is pushed, all the checks will pass.

rngadam commented 6 months ago

Docker image failed, after discussing with @ThomasCardin, this error is not yet managed. Once this pull request is pushed, all the checks will pass.

how is it not managed and which devsecops tracks this?

image

rngadam commented 6 months ago

@MaxenceGui how about moving this branch to the ai-cfia repo to follow our conventional way and have the checks pass?

MaxenceGui commented 6 months ago

@MaxenceGui how about moving this branch to the ai-cfia repo to follow our conventional way and have the checks pass?

Sure I propose to name the other repo temp_nachet_backend, then pull request from this fork to this one.

image

rngadam commented 6 months ago

Sure I propose to name the other repo temp_nachet_backend, then pull request from this fork to this one.

why are you creating a fork? you want to push your branch to the existing repo. Fork is an entirely different concept.

MaxenceGui commented 6 months ago

Sure I propose to name the other repo temp_nachet_backend, then pull request from this fork to this one.

why are you creating a fork? you want to push your branch to the existing repo. Fork is an entirely different concept.

Sorry, I misunderstood what you were suggesting

MaxenceGui commented 6 months ago

Merging into org. branch 62-drawing-red-box-error