ai-cfia / nachet-frontend

Frontend application for seed classification of images acquired from digital microscopes
MIT License
2 stars 2 forks source link

Migrate to Vite for Enhanced Development Experience #108

Closed CFIALeronB closed 1 month ago

CFIALeronB commented 2 months ago

This Pull Request encompasses the transition from create-react-app to Vite. The change aims to harness Vite's faster build times, out-of-the-box features, and overall improved development experience. Here's a brief overview of what has been done:

Changes:

Benefits:

Closes #104

rngadam commented 1 month ago

@CFIALeronB let's get this merged in

CFIALeronB commented 1 month ago

@CFIALeronB let's get this merged in

I'll be finalising and committing the automated tests and updated documentation today, and then we can move forward with the merge if all checks out!

rngadam commented 1 month ago

apparently if there are no tests with npm test the test suite still "passes".

image

1) npm test command should be updated to run vitest 2) by default, the Github workflow should fail when no tests are present

CFIALeronB commented 1 month ago

@rngadam Does everything look good for merging?

rngadam commented 1 month ago

@rngadam Does everything look good for merging?

yes, the test is passing and all other checks pass so looks good to me. Good basis to start adding more tests in future PR.

image