search

ai-cfia / nachet-frontend

Frontend application for seed classification of images acquired from digital microscopes
MIT License
2 stars 2 forks source link

Issue #91: added lint test #92

Closed ThomasCardin closed 3 months ago

ThomasCardin commented 3 months ago
ThomasCardin commented 3 months ago

@CFIALeronB Do you have an idea of what is failing in the lint-test?

rngadam commented 3 months ago

@CFIALeronB Do you have an idea of what is failing in the lint-test?

@ThomasCardin

tsconfig.json specifies an include of src/ but eslint is run as

eslint .

meaning all directories in the root get tested. should be:

eslint src/

probably since tsconfig.json, the list of directories to be lint'ed should be passed as parameter and default to src/

ThomasCardin commented 3 months ago

@ibrahim-kabir Here's the workflow that need a fix this workflow. If you have any questions, let me know :)

ThomasCardin commented 3 months ago

workflow upstream need change to lint src/

This is the issue https://github.com/ai-cfia/nachet-frontend/blob/91-as-a-developper-i-want-to-lint-my-project/package.json#L47 . Change the . to src/ . The workflow is functioning as intended

In this situation, it's possibly the developer's decision to lint the .. The purpose of this PR is solely to add the workflows related to this directory. Closing this PR.

@CFIALeronB if you have any question, feel free to ping me.

rngadam commented 3 months ago

@ThomasCardin I do not agree that we should ever merge pull requests that are failing the checks. If you do not want to fix the merge than reassign to a developer but do not merge.

image