search

ai-dock / comfyui

ComfyUI docker images for use in GPU cloud and local environments. Includes AI-Dock base for authentication and improved user experience.
Other
390 stars 143 forks source link

PreviewImage nodes result in copy errors #31

Open PoCTo opened 5 months ago

PoCTo commented 5 months ago

When I post a workflow json that has a PreviewImage to the API (via /rp-api/runsync), BaseHandler is unable to copy a file:

DEBUG  | test-c12c72b8-f825-4c0c-916e-68d62d92296d | run_job return: {'error': "[Errno 2] No such file or directory: '/workspace//ComfyUI/output//ComfyUI_temp_mqplo_00001_.png' -> '/workspace//ComfyUI/output/test-c12c72b8-f825-4c0c-916e-68d62d92296d/ComfyUI_temp_mqplo_00001_.png'"}

This is due to the fact that PreviewImage saves the image to the temp directory

It is questionable whether temp images must be returned. I guess it would be great if it can be configured

I propose to not iterate over images with type="temp" for now since otherwise it fails

robballantyne commented 5 months ago

I'll add this. I need to handle outputs more effectively because currently it's only looking at standard png but really should cover jpg, mp4 etc

Thanks

robballantyne commented 2 months ago

Most recent builds now return all output files of type "output". Temp files are still ignored for now but will be added soon if the workflow creates previews