search

ai-economy-simulator / ecosim-client

https://ecosim-client-fliptrails-projects.vercel.app
Apache License 2.0
1 stars 10 forks source link

Create a CustomLink React component which abstracts over Next.js and Fluent UI Link #4

Open fliptrail opened 9 months ago

fliptrail commented 9 months ago

We prefer to use Next.js Link component for functionality as it supports pre-fetching and maintains scrolls after navigation. However, to be consistent with Fluent UI principles, we need to use its Link component to display it on the UI.

Currently it has used as shown here: https://github.com/ai-economy-simulator/ecosim-client/blob/a0fdcca428ee1873a5014a46d3cc82712388b52e/src/app/components/footer.tsx#L18-L20

Create a custom component CustomLink which abstracts over this nesting. It should take a child JSX component as prop and nest it inside the NextLink component.

https://github.com/ai-economy-simulator/ecosim-client/blob/a0fdcca428ee1873a5014a46d3cc82712388b52e/src/app/components/link.tsx#L4

GauravGupta993 commented 9 months ago

I would like to work on this issue. Please assign this issue to me.

fliptrail commented 9 months ago

I've assigned it to you @GauravGupta993.