search

ai-forever / ner-bert

BERT-NER (nert-bert) with google bert https://github.com/google-research.
MIT License
407 stars 97 forks source link

a small bug in `get_mean_max_metric` function #21

Closed AaronHeee closed 5 years ago

AaronHeee commented 5 years ago

Thanks so much for your super nice implementation of NER-BERT! I'm writing to report a small bug.

We use the get_mean_max_metric in BERT-NER/modules/utils/plot_metrics.py to calculate the metric results, which will determine whether to save model during training time.

However, in this function, [3 + m_idx] in [float(h.split("\n")[-2].split()[3 + m_idx]) for h in history] should be [2 + m_idx], in order to obtain the correct results of target metrics.

Please fix this bug, thanks a lot!

king-menin commented 5 years ago

it depends from sklearn-crfsuite version