search

ai-glimpse / toyllm

Toy LLM
https://ai-glimpse.github.io/toyllm/
Apache License 2.0
1 stars 0 forks source link

Feat/load gpt2 pt weight #23

Closed shenxiangzhuang closed 2 months ago

shenxiangzhuang commented 2 months ago

Close #22

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve updates to multiple files in the project, focusing on enhancing the model configuration and initialization processes. Key modifications include the introduction of a new enumeration for model sizes, refactoring of the TextGenerator class to streamline model loading, and significant alterations to the GPTModel class to support size-based configuration. Additionally, updates to dependency management and .gitignore entries were made to improve project organization and maintainability.

Changes

File Change Summary
.gitignore Updated to ignore PyTorch model files and directories (*.pt, models/*).
pyproject.toml Added a comma after the last dependency entry for proper formatting.
toyllm/model/config.py Introduced GPTModelSize enum and updated GPTModelConfig with a new name attribute. Renamed and added model configurations.
toyllm/model/generate.py Refactored TextGenerator to simplify initialization by accepting a gpt_model parameter.
toyllm/model/gpt.py Modified GPTModel to accept model_size parameter and added methods for saving/loading model state.
toyllm/model/train.py Updated to use GPTModelSize for model instantiation and configuration, reflecting changes in model management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Train
    participant Model
    participant Generator

    User->>Train: Start training
    Train->>Model: Instantiate GPTModel with size
    Model->>Model: Load model configuration
    Train->>Generator: Instantiate TextGenerator with model
    Generator->>Model: Generate text
    Model-->>Generator: Return generated text
    Generator-->>User: Display generated text

Poem

🐇 In the garden of code, changes bloom bright,
With models and sizes, a new guiding light.
Text flows like rivers, smooth and so clear,
As rabbits rejoice, for the updates are here!
Hops of delight in the code's gentle dance,
Celebrate progress, give change a chance! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 30.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 37.69%. Comparing base (d7eb53c) to head (7c9380f). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
toyllm/model/gpt.py 16.12% 26 Missing :warning:
toyllm/model/generate.py 7.69% 12 Missing :warning:
toyllm/model/train.py 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #23 +/- ## ========================================== + Coverage 36.17% 37.69% +1.52% ========================================== Files 7 7 Lines 376 390 +14 ========================================== + Hits 136 147 +11 - Misses 240 243 +3 ``` | [Flag](https://app.codecov.io/gh/ai-glimpse/toyllm/pull/23/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ai-glimpse) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/ai-glimpse/toyllm/pull/23/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ai-glimpse) | `37.69% <30.00%> (+1.52%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ai-glimpse#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.