ai-republic / bms-to-inverter

Use, monitor and control any battery brand with any inverter! Application to read and monitor data from BMSes and write data to an inverter using any protocol (e.g. UART, RS485, ModBus or CAN)
https://github.com/ai-republic/bms-to-inverter
Other
32 stars 6 forks source link

Batteries with no content shown in the overview and webserver #17

Closed ai-republic closed 4 months ago

ai-republic commented 4 months ago

When using Pylon HV BMS with non-incremental identifiers for batteries there are batteries shown with no content in the overview and webserver.

ai-republic commented 4 months ago

I changed the incremental battery list to a battery mapping which dynamically will add the batteries depending on their identifier.

@jenshermans could you test this that there are no more batteries listed with SOC -1 and 0 (zero) values in the log?

jenshermans commented 4 months ago

BMS-to-Inverter.log

ai-republic commented 4 months ago

Did you update? Because it's still showing 2 battery packs.On 26/2/24, 17:29 Jens Hermans @.***> wrote:

BMS-to-Inverter.log —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

jenshermans commented 4 months ago

I'm pretty sure i did it, downloaded again and this is the current log. Still showing multiple BMS's. BMS-to-Inverter.log

ai-republic commented 4 months ago

Ok, thank you Jens. I will have to check that again in more detail.

ai-republic commented 4 months ago

@jenshermans please update again. There was a merge conflict so the last few changes were not committed. I think that's why you're still seeing the first invalid BMS. I also tested it emulating the Pylon HV BMS with receiving 0x42x1 messages and it looks fine (only 1 BMS showing correct values).

After that is fixed and running stable, I'll make a release so that you can always switch back to a working version if something in the main branch breaks.

jenshermans commented 4 months ago

Only showing one BMS now.

Noticed a little bug in the configurator, the "BMS-ID" keeps showing 0, even if configured something else.

Here i configured my id to 2; image When pressing edit, it shows ID: 0, in the edit screen.

BMS-to-Inverter.log

ai-republic commented 4 months ago

Hi Jens, super. And I also fixed the Configurator bug you found.

All looks good in your log!