Define port in environments

ai-traders / liget

NuGet server and cache running on kestrel in docker

MIT License

216 stars 29 forks source link

Define port in environments #12

Closed simenandre closed 5 years ago

simenandre commented 5 years ago

Hello 👋

We are using Liget – and we use Google App Engine. The problem is that App Engine requires us to use port 8080 for the load balancer. Right now, we just use the instance ip to communicate with Liget on port 9011. It would be super nice to be able to dynamically set that port.

We use a Dockerfile that looks like this:

FROM tomzo/liget:1.0.1

EXPOSE 9011

Maybe we could add a ENV to this?

tomzo commented 5 years ago

Makes sense, currently it is hardcoded in https://github.com/ai-traders/liget/blob/master/src/LiGet/Program.cs#L106

It could be parameterized with LIGET_LISTEN_PORT, defaulting to 9011

hmol commented 5 years ago

👋 @tomzo take a look at my pull request. I think I have solved this issue.

tomzo commented 5 years ago

@hmol thanks for the PR. It is released in 1.0.2