search

ai-traders / liget

NuGet server and cache running on kestrel in docker
MIT License
218 stars 29 forks source link

Upgrade to dotnet core 2.1 #4

Closed ElanHasson closed 5 years ago

ElanHasson commented 5 years ago

Some of the tests seem flaky and fail due to concurrency issues with file IO access. This happened on master too. Refactoring the tests to use randomized files or in memory packages to avoid this should be considered.

tomzo commented 5 years ago

Thanks. I haven't seen those issues, but this is possible. LiGet implementation of V2 is ported from old NuGet server, It can have issues. As I said in other issue, my intentions are to make a BaGet image which is a drop-in replacement for LiGet. I am porting tests from LiGet to BaGet and writing new ones. Please have a look at the fork and post your suggestions there - https://github.com/ai-traders/baget I should have V2 implemented today.

ElanHasson commented 5 years ago

Cool! Wasn't aware of BaGet. The dockerfile still uses the ask image to deploy versus using a production dotnet image. Is there a reason for this?

tomzo commented 5 years ago

The dockerfile still uses the ask image to deploy versus using a production dotnet image

Which dockerfile are you talking about?

ElanHasson commented 5 years ago

The BaGet one.

It uses the stretch image. I couldn't readily find information on it, but appears to have the sdk included in it, which isn't required at runtime.

What is the benefit of that image over the runtime containers?

tomzo commented 5 years ago

Ah, I see, you meant FROM microsoft/dotnet:2.1.402-sdk-stretch in my fork. It's a mistake, should be just the runtime. I will switch it shortly. Thanks.

alexanderfast commented 5 years ago

I need this PR to build, I dont know if the dependent pre-release packages went away or something.

/home/afast/liget/src/LiGet.App/LiGet.App.csproj : error NU1102: Unable to find package Nancy with version (>= 2.0.0-Pre1885) [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet.App/LiGet.App.csproj : error NU1102:   - Found 47 version(s) in nuget.org [ Nearest version: 2.0.0-clinteastwood ] [/home/afast/liget/LiGet.sln]
/home/afast/liget/tests/LiGet.Tests/LiGet.Tests.csproj : error NU1102: Unable to find package Nancy with version (>= 2.0.0-Pre1885) [/home/afast/liget/LiGet.sln]
/home/afast/liget/tests/LiGet.Tests/LiGet.Tests.csproj : error NU1102:   - Found 47 version(s) in nuget.org [ Nearest version: 2.0.0-clinteastwood ] [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet.App/LiGet.App.csproj : error NU1102: Unable to find package Nancy.Bootstrappers.Autofac with version (>= 2.0.0-Pre486) [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet.App/LiGet.App.csproj : error NU1102:   - Found 39 version(s) in nuget.org [ Nearest version: 2.0.0-clinteastwood ] [/home/afast/liget/LiGet.sln]
/home/afast/liget/tests/LiGet.Tests/LiGet.Tests.csproj : error NU1102: Unable to find package Nancy.Bootstrappers.Autofac with version (>= 2.0.0-Pre486) [/home/afast/liget/LiGet.sln]
/home/afast/liget/tests/LiGet.Tests/LiGet.Tests.csproj : error NU1102:   - Found 39 version(s) in nuget.org [ Nearest version: 2.0.0-clinteastwood ] [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet/LiGet.csproj : error NU1102: Unable to find package Nancy with version (>= 2.0.0-Pre1885) [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet/LiGet.csproj : error NU1102:   - Found 47 version(s) in nuget.org [ Nearest version: 2.0.0-clinteastwood ] [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet/LiGet.csproj : error NU1102: Unable to find package Nancy.Bootstrappers.Autofac with version (>= 2.0.0-Pre486) [/home/afast/liget/LiGet.sln]
/home/afast/liget/src/LiGet/LiGet.csproj : error NU1102:   - Found 39 version(s) in nuget.org [ Nearest version: 2.0.0-clinteastwood ] [/home/afast/liget/LiGet.sln]
tomzo commented 5 years ago

Yes, they were probably removed. I was lazy on merging this due to work on BaGet migration.

alexanderfast commented 5 years ago

What's the BaGet migration? Are you replacing Liget with BaGet, obsoleting this project?

tomzo commented 5 years ago

@Mizipzor I already have a BaGet fork which is a drop-in replacement for LiGet. My initial plan was to obsolete this project and provide migration scripts for all LiGet users to move to BaGet. But recently it turns out that upstream author of BaGet will not merge my e2e tests and release cycle. So probably I will merge parts of BaGet fork into LiGet. I haven't had time to work on this yet.