Closed ai closed 1 month ago
@ai could you please clarify how to run tests in the project?
If I understand it correctly the test
command from package.json
runs:
But what about the tests themselves?
test:coverage
script is a script of unit tests. It runs better-node-test
, which is a wrapper around node --test
.
You need to update Node.js (I recommend latest 20.x).
I think that the issue might be more complex because of various possible item roles:
menu
and menubar
require menuitem
item role - see the w3c examplelistbox
requires option
item role - the w3c exampletablist
require tab
item role - exampleAs for toolbar
it might be a problem because it can contains different types of items e.g. button
, spinbutton
, checkbox
, radio
etc - the toolbar example
I propose to support menubar
, listbox
, and tablist
within this issue and create a separate one for toolbar
.
@ai what do you think?
Yes, we can do toolbox
in a separated PR
@ai here is my draft PR https://github.com/ai/keyux/pull/16 (without toolbox
). Can you please look at it?
I have not added new groups to the doc yet. I need some clarifications. Do we want to add all new supported focus group types to the doc?
upd I found the explanation:
Update docs to explain listbox and tablist support
I will update the PR tomorrow
Forgot to close
menuKeyUX
tofocusGroupKeyUX
with all files and testsrole="listbox"
support in additional torole="menu"
role="tablist"
support in additional torole="menu"
role="toolbar"
support with horizontal default direction.role="menubar"
support with horizontal default direction.listbox
andtablist
support