ai / nanoid

A tiny (124 bytes), secure, URL-friendly, unique string ID generator for JavaScript
https://zelark.github.io/nano-id-cc/
MIT License
24.33k stars 788 forks source link

Replace deprecated `expo-random` package #415

Closed silvestreh closed 1 year ago

silvestreh commented 1 year ago

Removes usage of the now deprecated expo-random. Closes #414

ai commented 1 year ago

Should we release it as Nano ID 5.0?

silvestreh commented 1 year ago

🤔 technically speaking, expo-random has been merged into expo-crypto bringing the functionality over to the newer package. There are no breaking API changes, but then again, people using older Expo SDKs will probably be greeted with an error during build time about the expo-crypto not being found.

I believe tagging a major release, even with no new functionality, would make sense.

ai commented 1 year ago

I will wait for Node.js 14 to release to make more major changes together.

ai commented 1 year ago

@silvestreh BTW, we are using expo-crypto only for async version.

Maybe we should use just browser sync version instead with polyfill (and wrap it to Promise)? Too rare use case for special version.

ai commented 1 year ago

Done 0276499