07 urwi rotation correction

ai03-2725 / another-keyboard-builder

An exact mechanical keyboard plate creator

GNU Affero General Public License v3.0

88 stars 16 forks source link

07 urwi rotation correction #13

Open ursaw opened 4 years ago

ursaw commented 4 years ago

fixes ai03-2725/another-keyboard-builder#2 and ai03-2725/another-keyboard-builder#7

topics to consider:

not all attributes of a switch covered (h2, w2, _r?)
package structure (can be put all in one file).
~~indention tab vs. spaces in same files~~
Read file directly in KLE_reader()
unit.test files not up to date

@ai03-2725 : What changes / tests / quality requirements are necessary for this pull reques?t

ai03-2725 commented 4 years ago

Apologies for the extremely delayed response; I always seem to forget about checking the PRs for my projects. I'll check asap against a few generic rotated files and see if the output is correct, then merge the PR.

MxBlu commented 3 years ago

You've changed a lot of things in this PR, so it's a little difficult to review. I'll see if I can review it and get it merged over the next week or so.