search

ai2cm / fv3config

Manipulate FV3GFS run directories
Apache License 2.0
1 stars 0 forks source link

Ignore orography if empty list #135

Closed ofuhrer closed 3 years ago

ofuhrer commented 3 years ago

This PR ignores orography, in case the user specifies an empty list. There's probably a better way to do this, so I am a taker for alternatives.

mcgibbon commented 3 years ago

Code looks great! You've added the functionality that orographic forcing can be passed as an asset list instead of only as a directory path. Can you look in the tests to see what test cases exist for initial_conditions for asset lists and add the same tests for orographic_forcing?