Closed nbren12 closed 2 years ago
I think I'm running into this problem again.
I'm motivated to fix this since it consumed 45 minutes this morning for me. The current workaround is to set
FSSPEC_GS_PROJECT=vcm-ml
# or
GOOGLE_CLOUD_PROJECT=vcm-ml
in the image.
I think a couple options are to
Any preference @oliverwm1 @mcgibbon ? I'd vote for removing the requester_pays flag for simplicity. I think this would seamlessly support all the auth patterns we use on the teams. Any external users could then enable requestor pays by using FSSPEC_GS_
env vars.
I am +1 on removing the requester_pays=True
default.
Maybe worth verifying that the FSSPEC_GS_REQUESTOR_PAYS
env var configuration works as expected? I don't think I've ever used it.
Maybe worth verifying that the
FSSPEC_GS_REQUESTOR_PAYS
env var configuration works as expected? I don't think I've ever used it.
Looks like it works:
$ FSSPEC_GS_REQUESTER_PAYS=True python3 -c 'import fsspec; print( fsspec.filesystem("gs").requester_pays)'
True
$ FSSPEC_GS_REQUESTER_PAYS=False python3 -c 'import fsspec; print( fsspec.filesystem("gs").requester_pays)'
False
I get the following complaint when running in docker with the
~/.config/gcloud
bind-mounted into the container.This error occurs because of the requester_pays flag here: https://github.com/ai2cm/fv3config/blob/544eaf1bc6f1c4617cd8ee6bd3298136ed180f4c/fv3config/filesystem.py#L25
See this debugger output:
I suggest removing this flag. It is not applicable in all environment and can be controlled by setting the
if needed.