Closed mcgibbon closed 4 years ago
LGTM. Can you add the --kubernetes
option to the docs?
Is there a plan to allow more precise specification of Kubernetes resources from the command line? The feature as it currently stands seems of somewhat limited utility if it only allows runs with cpu_count=1 and memory_gb=3.6GB, the current defaults for run_kubernetes
.
@oliverwm1 I think it would be fair for the fv3run
CLI to support all the current parameters of run_kuberenetes
. That said, @mcgibbon and I are concerned that adding more features to functions like run_kuberentes
(e.g. volume mounts etc) could result in a function with so many arguments that it basically equivalent to a k8s yaml. At that point, I think we should just write raw K8s jobs as yaml files, templates for which could be generated with run_k8s.
After discussing with @oliverwm1 and @nbren12 I'm modifying this so --kubernetes
will output the job yml to stdout instead. Will get in touch when it's ready for re-review.
Major changes:
--kubernetes
command-line flag to output a kubernetes config yaml to stdoutMinor changes:
filesystem.is_local_path
naming to be package-private instead of module-private