ai2cm / fv3config

Manipulate FV3GFS run directories
Apache License 2.0
1 stars 0 forks source link

Add --kubernetes flag and run model in outdir when outdir is local #75

Closed mcgibbon closed 4 years ago

mcgibbon commented 4 years ago

Major changes:

Minor changes:

oliverwm1 commented 4 years ago

LGTM. Can you add the --kubernetes option to the docs?

Is there a plan to allow more precise specification of Kubernetes resources from the command line? The feature as it currently stands seems of somewhat limited utility if it only allows runs with cpu_count=1 and memory_gb=3.6GB, the current defaults for run_kubernetes.

nbren12 commented 4 years ago

@oliverwm1 I think it would be fair for the fv3run CLI to support all the current parameters of run_kuberenetes. That said, @mcgibbon and I are concerned that adding more features to functions like run_kuberentes (e.g. volume mounts etc) could result in a function with so many arguments that it basically equivalent to a k8s yaml. At that point, I think we should just write raw K8s jobs as yaml files, templates for which could be generated with run_k8s.

mcgibbon commented 4 years ago

After discussing with @oliverwm1 and @nbren12 I'm modifying this so --kubernetes will output the job yml to stdout instead. Will get in touch when it's ready for re-review.