Copy configuration dict into rundirectory

ai2cm / fv3config

Manipulate FV3GFS run directories

Apache License 2.0

1 stars 0 forks source link

Copy configuration dict into rundirectory #95

Closed nbren12 closed 4 years ago

nbren12 commented 4 years ago

Many uses of the python wrapper require a configuration dictionary to be saved as a yaml file named fv3config.yml in the run directory root.

This PR adds this simple capability.

The test is a little tautological, but oh well...

mcgibbon commented 4 years ago

I think you also need to modify fv3run so it doesn’t copy the dictionary (what is now a duplicate time). We're planning to remove that code, but it's not removed yet.

Since the tests still pass, it's probably fine to double-copy the dictionary, and you could choose not to do this.

nbren12 commented 4 years ago

This is ready for re-review @mcgibbon. I added the end to end test and renamed the test_cache.py to clarify.

nbren12 commented 4 years ago

@mcgibbon @ofuhrer What's up with Jenkins?

ofuhrer commented 4 years ago

@mcgibbon @ofuhrer What's up with Jenkins?

Not sure, problem occurs both on GCP instances as well as Daint when installing requirements.txt as far as I can see but does not seem to be related to content of PR. @mcgibbon ?

ofuhrer commented 4 years ago

launch jenkins

nbren12 commented 4 years ago

It looks like wheel needs to be installed. Sometimes older versions of the system python/setuptools don't come with it.