ai2cm / fv3gfs-fortran

FV3GFS Fortran for internal development at AI2
Other
6 stars 9 forks source link

Specify diagnostic tables explicitly in regression test configs #355

Closed spencerkclark closed 1 year ago

spencerkclark commented 1 year ago

This PR addresses #354. Note this required specifying shorter output names for the vertically_integrated_tendency_of_air_temperature_due_to_shortwave_heating_assuming_clear_sky_coarse and vertically_integrated_tendency_of_air_temperature_due_to_longwave_heating_assuming_clear_sky_coarse diagnostics in the coarse-graining tests, since there is a 256 character line length limit on the diag_table imposed by FMS. We worked around this previously by shortening the output names some and stripping out all spaces in each line, but fv3config's formatting includes spaces. This means that we had to update the checksums for those tests.

spencerkclark commented 1 year ago

@elynnwu do you mean how far back are these configs compatible with older versions of fv3config or was your concern whether longer diag_table lines were compatible with previous versions of FMS?

elynnwu commented 1 year ago

@elynnwu do you mean how far back are these configs compatible with older versions of fv3config or was your concern whether longer diag_table lines were compatible with previous versions of FMS?

Is it still possible to input a file path to diag_table?

spencerkclark commented 1 year ago

Ah gotcha! Indeed it is still an option to provide a config with a file path referring to a diag_table; I just opted for this newer approach in these configs since it's nicer to have things more in one place.