ai2cm / fv3gfs-wrapper

Python wrapper for the FV3-based global climate model
Other
28 stars 3 forks source link

`set_state_mass_conserving` only conserves dry air mass #257

Open oliverwm1 opened 3 years ago

oliverwm1 commented 3 years ago

Because "mixing ratios" (or more accurately, specific masses) of water species in FV3 are defined relative to total mass:

https://github.com/VulcanClimateModeling/fv3gfs-wrapper/blob/1d049991c7c7bbddebff3b52b5ac8820d0f5e816/fv3gfs/wrapper/thermodynamics.py#L18-L20

then if any particular water species is updated, the other water species' "mixing ratios" should be changed to reflect this update. Currently, this conservation of mass is only enforced for dry air mass (i.e. the pressure thickness is updated whenever any water species are modified in set_state_mass_conserving).