ai2cm / fv3gfs-wrapper

Python wrapper for the FV3-based global climate model
Other
28 stars 3 forks source link

making the bit-for-bit tests less brittle #271

Closed nbren12 closed 3 years ago

nbren12 commented 3 years ago

The regression tests duplicate the responsibility of the Fortran model's test suite somewhat. The fv3gfs-fortran tests ensure that its results are bit-for-bit compatible through refactors when built in an identical environment. By also verifying the same checksums, the fv3gfs-wrapper tests essentially enforce build environment of the Fortran model and wrapper be the same. This is not easy to do with loosely coupled repositories.

Should we re-target these tests to instead ensure that the wrapper is bit-for-bit compatible with w/e version of fv3gfs-fortran is installed in the environment? The tests would look like

  1. run fv3.exe
  2. save checkusms
  3. run wrapper
  4. save checksums
  5. compare 2 and 4.

This issue is blocking my proposed changes to use nix as package manager (see #268).