ai2cm / fv3gfs-wrapper

Python wrapper for the FV3-based global climate model
Other
27 stars 3 forks source link

Use pace-util rather than fv3gfs-util? #298

Closed nbren12 closed 2 years ago

nbren12 commented 2 years ago

@mcgibbon Should we update the dependency to use the new home of fv3gfs-util? This prevents fv3net from using pace-util.

https://github.com/ai2cm/fv3gfs-wrapper/blob/5e9dc78117ad470ef84bff51689333b4ecf0fca7/setup.py#L60

mcgibbon commented 2 years ago

I think that makes sense. We can also have it use the version on pypi. I don't think we need the submodule anymore, because we're not actively developing this package.

nbren12 commented 2 years ago

I think it's a reasonably high priority so that fv3net doesn't get stuck on a non-maintained pypi package. Also refactoring any fv3gfs.util imports in fv3net.

mcgibbon commented 2 years ago

Fixed by https://github.com/ai2cm/fv3gfs-wrapper/pull/299