ai2cm / fv3net

explore the FV3 data for parameterization
MIT License
16 stars 3 forks source link

radiation: fix broken year warnings #2226

Closed brianhenn closed 1 year ago

brianhenn commented 1 year ago

The radiation port, if run for certain years, had warning statements that inadvertently crashed it. This PR replaces them with print statements (the way the rest of the port outputs to console at runtime; should probably be replaced by logging throughout but that's a separate issue).

Coverage reports (updated automatically):

brianhenn commented 1 year ago

Fair question. Yes I think the intent is to get the year with same position in the solar cycle as the desired year, but we could also ask GFDL for an updated solar constant data file.

spencerkclark commented 1 year ago

Last month I happened to add an updated set of forcing files to gs://vcm-fv3config/data/base_forcing/v1.2. Other than the following updates, all other files are identical to their previous versions:

Indeed it looks like this code is complaining about the solar constant data, so it seems like this update should fix it!

brianhenn commented 1 year ago

Cool thanks @spencerkclark . Will be easy to update the GCS file that the rad port pulls its solar data from (which is just a reformatted copy of the original forcing files).