ai2cm / fv3net

explore the FV3 data for parameterization
MIT License
16 stars 3 forks source link

Fix hybrid model bug in concatenting reservoir state and hybrid state #2259

Closed AnnaKwa closed 1 year ago

AnnaKwa commented 1 year ago

Currently the HybridReservoirModel.predict method does

readout_input = np.concatenate([readout_input_from_reservoir, hybrid_input])

to combine the two sources of input to the readout layer. This is incorrect since the hidden state and hybrid inputs for each subdomain need to be continuous in the final array.