ai2cm / fv3net

explore the FV3 data for parameterization
MIT License
16 stars 3 forks source link

Radiation port lacks a regression test #2389

Open brianhenn opened 10 months ago

brianhenn commented 10 months ago

Since the deletion of the serialized fv3gfs-fortran data that supported the regression test of the python port of the radiation code, the port lacks a functioning regression test. That test was brittle and had high overhead because it depended on reading serialbox-generated data, so replacing it with a python-only test using the current code makes sense anyway. One challenge will be how to make a regression test for the stochastic MCICA radiation scheme -- the prior test actually serialized all of the random numbers, which might be difficult to reimplement. Instead we could port a deterministic (non-MC) option that already exists in the Fortran version and test that, or we could just test the deterministic clear sky part.