clean up checking - Githubissues

ai2cm / pace

Implementation of the FV3GFS / SHiELD atmospheric model in Python

https://ai2cm.github.io/pace/

Apache License 2.0

37 stars 12 forks source link

clean up checking #284

Closed twicki closed 2 years ago

twicki commented 2 years ago

Purpose

There was a bug in decomposition.py to raise a faulty assertion when just running on a higher node-count. This fixes that problem.

Code changes:

Added the correct check for faulty layouts in stencil_config.py
Removed the faulty check in decomposition.py
added test for this in test_compilation_config.py

Checklist

Before submitting this PR, please make sure:

[x] You have followed the coding standards guidelines established at Code Review Checklist.
[x] Docstrings and type hints are added to new and updated routines, as appropriate
[x] Unit tests are added or updated for non-stencil code changes