ai2cm / pace

Implementation of the FV3GFS / SHiELD atmospheric model in Python
https://ai2cm.github.io/pace/
Apache License 2.0
37 stars 12 forks source link

Feature/tc init #346

Closed ajdas1 closed 1 year ago

ajdas1 commented 2 years ago

Purpose

Creating an initialization for the tropical cyclone case (following the example of how the baroclinic init was set up). It doesn't quite work all the way. I believe that the initial fortran state is set correctly - when I compare it to the fortran restart files written out 1 second after restart, everything is identical except for small changes in winds. But after 1 time step, all fields are set to nan. I didn't have quite enough time to figure out why and how to fix it.

Code changes:

Checklist

Before submitting this PR, please make sure:

Additionally, if this PR contains code authored by new contributors:

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

FlorianDeconinck commented 1 year ago

Reverting the PR to inject only the WIP TC init code. All other changes to restart work has been removed.