Currently PerformanceConfig has attributes that aren't representable by or loaded from yaml, which causes issues when serializing it back to disk. This PR separates those concerns into a PerformanceCollector class.
Resolves #361
Code changes:
Added PerformanceCollector, NullPerformanceCollector, and AbstractPerformanceCollector
renamed "performance_mode" setting in PerformanceConfig to "collect_performance"
removed runtime values from PerformanceConfig
Checklist
Before submitting this PR, please make sure:
[x] You have followed the coding standards guidelines established at Code Review Checklist.
[x] Docstrings and type hints are added to new and updated routines, as appropriate
[x] All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
[x] For each public change and fix in pace-util, HISTORY has been updated
[x] Unit tests are added or updated for non-stencil code changes
mcgibbon
commented
2 years ago
Purpose
Currently PerformanceConfig has attributes that aren't representable by or loaded from yaml, which causes issues when serializing it back to disk. This PR separates those concerns into a PerformanceCollector class.
Resolves #361
Code changes:
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updated