Netcdf monitor compatible with gpu backend - Githubissues

ai2cm / pace

Implementation of the FV3GFS / SHiELD atmospheric model in Python

https://ai2cm.github.io/pace/

Apache License 2.0

37 stars 12 forks source link

Netcdf monitor compatible with gpu backend #367

Closed elynnwu closed 2 years ago

elynnwu commented 2 years ago

Purpose

The first pass of netcdf monitor did not work for gpu backend, this PR fixes the issue.

Code changes:

netcdf_monitor: use to_numpy whenever .view is referenced. When quantity.data_array is called, make DataArray from quantity directly.
zarr_monitor: factor try except statement to to_numpy to be used for both zarr and netcdf
convert: new function to_numpy added

Checklist

Before submitting this PR, please make sure:

[x] You have followed the coding standards guidelines established at Code Review Checklist.
[ ] Docstrings and type hints are added to new and updated routines, as appropriate
[ ] All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
[ ] For each public change and fix in pace-util, HISTORY has been updated
[ ] Unit tests are added or updated for non-stencil code changes