Inline some helper functions in driver - Githubissues

ai2cm / pace

Implementation of the FV3GFS / SHiELD atmospheric model in Python

https://ai2cm.github.io/pace/

Apache License 2.0

37 stars 12 forks source link

Inline some helper functions in driver #372

Closed mcgibbon closed 1 year ago

mcgibbon commented 1 year ago

Purpose

This PR makes small cleanups in driver before presenting it to GFDL

Code changes:

Inlined driver._step_dynamics and driver._step_physcs
Made driver methods update_driver_with_communicator and end_of_step_actions private

Checklist

Before submitting this PR, please make sure:

[x] You have followed the coding standards guidelines established at Code Review Checklist.
[x] Docstrings and type hints are added to new and updated routines, as appropriate
[x] All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
[x] For each public change and fix in pace-util, HISTORY has been updated
[x] Unit tests are added or updated for non-stencil code changes