All storage temporaries are now Quantity - Githubissues

ai2cm / pace

Implementation of the FV3GFS / SHiELD atmospheric model in Python

https://ai2cm.github.io/pace/

Apache License 2.0

37 stars 12 forks source link

All storage temporaries are now Quantity #377

Closed mcgibbon closed 1 year ago

mcgibbon commented 1 year ago

Purpose

This PR refactors all usage of storages to Quantity, other than in test code.

Code changes:

get_quantity_halo_spec method is moved from GridIndexing to QuantityFactory
all internal temporaries in physics, fv3core, and coupling code are now Quantity instead of storage

Checklist

Before submitting this PR, please make sure:

[x] You have followed the coding standards guidelines established at Code Review Checklist.
[x] Docstrings and type hints are added to new and updated routines, as appropriate
[x] All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
[x] For each public change and fix in pace-util, HISTORY has been updated
[x] Unit tests are added or updated for non-stencil code changes