Closed rdnfn closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Love it already before reviewing! 😉 😍
Thanks a lot for the review @herbiebradley! Was able to address most points in 42eae9e, and created Issue #50 for the remaining performance improvements, to be dealt with at a later point.
Introducing
GeoGraphViewer
🎉 ... this PR adds theGeoGraphViewer
visualisation class and a bunch of code that enables it. As theGeoGraphViewer
is a fairly complex widget, this PR is somewhat lengthy, apologies in advance! Thanks a lot for your review!Main changes:
visualisation/*
. The oldmodels/visualisation.py
has been removed.GeoGraphViewer
class (invisualisation/geoviewer.py
): this allows us to visualise GeoGraphs interactively.visualisation/control_widgets.py
): these make up the side control panel seen in demos. See architecture image below for a rough outline how they relate and are added to theGeoGraphViewer
.Other changes:
GeoGraphViewer
. These are invisualisation/widget_utils.py
visualisation/folium_utils.py
(old functions fromvisualisation.py
, no need to review)visualisation/graph_utils.py
(old functions fromvisualisation.py
, no need to review)data_loading/test_data.py
visualisation/style.py
that contains constants defining the plotting style of graph, etc. inGeoGraphViewer
.requirements/dev-requirements.txt
notebooks/exploratory/rdnfn-8-polesia-geographviewer-demo.ipynb
will likely be interesting, which is the demo on the Polesia data. Feel free to use it, it should work with the environment created viamake env
(if you updated it to new requirements)FoliumGeoGraphViewer
class (ingeoviewer.py
)Architecture![Screenshot 2021-03-15 at 20 51 38](https://user-images.githubusercontent.com/75615911/111219703-4313e080-85d0-11eb-9273-f2daa7f9c0a7.png)
GeoGraphViewer demo![Screenshot 2021-03-15 at 20 47 42](https://user-images.githubusercontent.com/75615911/111219756-4c04b200-85d0-11eb-8c6e-0abcde993b8a.png)