`sterror` not correctly piped - Githubissues

ai4os / DEEPaaS

A REST API to serve machine learning and deep learning models

https://deepaas.readthedocs.io

Apache License 2.0

35 stars 15 forks source link

`sterror` not correctly piped #118

Open IgnacioHeredia opened 11 months ago

IgnacioHeredia commented 11 months ago

Description

Errors are not correctly piped. An error in the module code that prevents deepaas from launching is piped to stout, not sterr.

Steps to Reproduce

Introduce error in module (raise Exception('some error'))
Launch deepaas: deepaas-run

stout:

...
2023-07-26 14:05:38.595 149055 ERROR deepaas   File "/home/iheredia/ignacio/projects/deephdc/apps/demo_app/demo_app/api.py", line 103, in get_predict_args
2023-07-26 14:05:38.595 149055 ERROR deepaas     raise Exception('some error')
2023-07-26 14:05:38.595 149055 ERROR deepaas Exception: some error
2023-07-26 14:05:38.595 149055 ERROR deepaas

sterr:

Two things might occur:

if Exception is raised in get_*_args, the deepaas process ends (with empty sterr)
if Exception was raised outside get_*_args, deepaas process does not end (an ERROR is just shown in stout).

In both cases, behaviour is incorrect.

Expected behavior:

Error message is in sterr. deepaas should not launch if an error is raised outside get_*_args (though is coorectly ending if error is inside).

Actual behavior

Error message is in stout. deepaas launching despite error.

Versions

2.0.0