search

ai5 / reviewing-a-pull-request

https://lab.github.com/githubtraining/reviewing-pull-requests
MIT License
0 stars 0 forks source link

Welcome #1

Closed github-learning-lab[bot] closed 2 years ago

github-learning-lab[bot] commented 2 years ago

Welcome!

Hello and welcome! In this course you will learn how you can get your best work done in pull requests. You'll learn when and how to request a review, how to review someone else's code, and how to respond to reviews. To do this, we'll be playing around with the code in this repository that makes a simple Tetris game.

If you'd like, you can use GitHub Pages to host your Tetris game. Just go to the Settings tab of this repository. Scroll down to GitHub Pages and select main as a Source.

New to GitHub?

For this course, you'll need some background knowledge. If you need a refresher on the GitHub flow, check out the Introduction to GitHub course.

Pull Requests Reviews 101

Reviewing a pull request is an opportunity to examine another contributor's changes. While reviewing a pull request, you can extrapolate how someone else solved a problem. It's an awesome opportunity to learn more about how the code works and how others solve problems. Reviewing a pull request is a great learning opportunity!

Step 1: Add assignees for issues and pull requests

Assignees on issues and pull requests let other team members know who is responsible. The assignee oversees the issue or pull request in an accessible and visible way.

:keyboard: Activity: Assign yourself to this issue

  1. On the right side of the screen, click the assign yourself text under the Assignees section

I'll respond below for your next step

Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response, wait a few seconds and refresh the page for your next steps.

github-learning-lab[bot] commented 2 years ago

Nice work, @ai5! Assigning yourself to an issue is a great way to let people know what you are working on. Once you begin working, it's important to get feedback on your work through reviews.

Learn more in the next pull request