ai50 / projects

19 stars 4 forks source link

Bug in crossword tests #4

Open doublethink13 opened 8 months ago

doublethink13 commented 8 months ago

In the crossword tests file there are two tests with the same name, consistent3. See lines 490 and 516.

When I run check50, this is the result I get:

# ...
:) consistent identifies consistent assignment
:) consistent identifies when assignment doesn't meet unary constraints
:) consistent identifies when assignment doesn't meet binary constraints
:) consistent identifies consistent incomplete assignments
# ...

It's missing the test named consistent identifies when assignment doesn't meet uniqueness constraints.

doublethink13 commented 8 months ago

This also happens for the parser assignment:

Missing one of the parser's tests:

# ...
:) preprocess removes tokens without alphabetic characters
:) parser can parse simple sentence
:) parser can parse more complex sentences
:) parser avoids over-generalizing to syntactically incorrect sentences
:) np_chunk identifies noun phrase
# ...